Dev compute microsoft.compute 2019 05 01 preview #5419

NarayanThiru · 2019-03-18T22:47:22Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…01 to version 2019-05-01-preview

AutorestCI · 2019-03-18T22:48:48Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout edb103f8b232091b3794b136e49b27c2e7967749
  stderr: 'fatal: reference is not a tree: edb103f8b232091b3794b136e49b27c2e7967749'

AutorestCI · 2019-03-18T22:49:33Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout edb103f8b232091b3794b136e49b27c2e7967749
  stderr: 'fatal: reference is not a tree: edb103f8b232091b3794b136e49b27c2e7967749'

AutorestCI · 2019-03-18T22:49:37Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout edb103f8b232091b3794b136e49b27c2e7967749
  stderr: 'fatal: reference is not a tree: edb103f8b232091b3794b136e49b27c2e7967749'

AutorestCI · 2019-03-18T22:50:33Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4988

AutorestCI · 2019-03-18T22:52:08Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout edb103f8b232091b3794b136e49b27c2e7967749
  stderr: 'fatal: reference is not a tree: edb103f8b232091b3794b136e49b27c2e7967749'

azuresdkci · 2019-03-18T22:53:48Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-18T22:54:08Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout edb103f8b232091b3794b136e49b27c2e7967749
  stderr: 'fatal: reference is not a tree: edb103f8b232091b3794b136e49b27c2e7967749'

REST Spec PR 'Azure/azure-rest-api-specs#5419' REST Spec PR Author 'NarayanThiru' REST Spec PR Last commit

jhendrixMSFT

I don't see ScriptJob.json in the README, is that intentional?

...ication/compute/resource-manager/Microsoft.Compute/preview/2019-05-01-preview/ScriptJob.json

KrisBash

Signing off with comments

KrisBash · 2019-04-02T16:36:41Z

...ication/compute/resource-manager/Microsoft.Compute/preview/2019-05-01-preview/ScriptJob.json

+    }
+  },
+  "definitions": {
+    "Resource": {


FYI, you can reference the common models in: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json

KrisBash · 2019-04-02T16:37:35Z

...ication/compute/resource-manager/Microsoft.Compute/preview/2019-05-01-preview/ScriptJob.json

+    },
+    "JobCreateProperties": {
+      "description": "Properties supplied to create a job.",
+      "properties": {


Is timeout not user-specified?

jhendrixMSFT · 2019-04-08T16:18:21Z

@NarayanThiru can you please rebase on top of latest master?

dsgouda · 2019-04-15T16:57:06Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5419' REST Spec PR Author 'NarayanThiru' REST Spec PR Last commit

adxsdknet · 2019-04-15T17:04:57Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5809
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@0ef26a4

jhendrixMSFT · 2019-04-15T18:18:05Z

@NarayanThiru will close by EOD if no update.

jhendrixMSFT · 2019-04-17T20:37:38Z

Closing due to inactivity. Please reopen when ready to engage.

NarayanThiru and others added 4 commits March 18, 2019 15:29

Adds base for updating Microsoft.Compute from version stable/2018-10-…

d0e79c4

…01 to version 2019-05-01-preview

Updates readme

aec22b3

Updates API version in new specs and examples

1a9edba

RunScripts Public Preview

59acea1

AutorestCI mentioned this pull request Mar 18, 2019

[AutoPR compute/resource-manager] Dev compute microsoft.compute 2019 05 01 preview Azure/azure-sdk-for-js#1627

Closed

AutorestCI mentioned this pull request Mar 18, 2019

[AutoPR compute/resource-manager] Dev compute microsoft.compute 2019 05 01 preview Azure/azure-sdk-for-ruby#2342

Closed

AutorestCI mentioned this pull request Mar 18, 2019

[AutoPR compute/resource-manager] Dev compute microsoft.compute 2019 05 01 preview Azure/azure-sdk-for-node#4956

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 18, 2019

.NET SDK Resource Provider:'Compute'

7bc603c

REST Spec PR 'Azure/azure-rest-api-specs#5419' REST Spec PR Author 'NarayanThiru' REST Spec PR Last commit

azuresdkci assigned jhendrixMSFT Mar 18, 2019

azuresdkci requested a review from jhendrixMSFT March 18, 2019 22:59

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 18, 2019

jhendrixMSFT requested changes Mar 19, 2019

View reviewed changes

Address comments - 1

280a841

This was referenced Mar 20, 2019

[AutoPR compute/resource-manager] Dev compute microsoft.compute 2019 05 01 preview Azure/azure-sdk-for-js#1670

Closed

[AutoPR compute/resource-manager] Dev compute microsoft.compute 2019 05 01 preview Azure/azure-sdk-for-node#4988

Closed

KrisBash approved these changes Apr 2, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 2, 2019

Azure deleted a comment from adxsdknet Apr 15, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 15, 2019

.NET SDK Resource Provider:'Compute'

0ef26a4

REST Spec PR 'Azure/azure-rest-api-specs#5419' REST Spec PR Author 'NarayanThiru' REST Spec PR Last commit

jhendrixMSFT closed this Apr 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev compute microsoft.compute 2019 05 01 preview #5419

Dev compute microsoft.compute 2019 05 01 preview #5419

NarayanThiru commented Mar 18, 2019

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

azuresdkci commented Mar 18, 2019

AutorestCI commented Mar 18, 2019 •

edited

Loading

jhendrixMSFT left a comment

KrisBash left a comment

KrisBash Apr 2, 2019

KrisBash Apr 2, 2019

jhendrixMSFT commented Apr 8, 2019

dsgouda commented Apr 15, 2019

adxsdknet commented Apr 15, 2019

jhendrixMSFT commented Apr 15, 2019

jhendrixMSFT commented Apr 17, 2019

Dev compute microsoft.compute 2019 05 01 preview #5419

Dev compute microsoft.compute 2019 05 01 preview #5419

Conversation

NarayanThiru commented Mar 18, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Mar 18, 2019

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-java

jhendrixMSFT left a comment

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

KrisBash Apr 2, 2019

Choose a reason for hiding this comment

KrisBash Apr 2, 2019

Choose a reason for hiding this comment

jhendrixMSFT commented Apr 8, 2019

dsgouda commented Apr 15, 2019

adxsdknet commented Apr 15, 2019

Automation for azure-sdk-for-net

jhendrixMSFT commented Apr 15, 2019

jhendrixMSFT commented Apr 17, 2019

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading